pyktx (Python bindings for libktx) #665
Conversation
|
Been pullin' my hair for a while and it turns out 64-bit Windows ships with 32-bit versions of Python. How convenient! |
|
I'm mystified by the VS2015 build issue. It shows as red but in the log it appears to have completed successfully. Don't worry about it. I shall be removing the VS2015 build from CI as soon as I've been able to release 4.1.0 and maybe sooner. Since I will not be able to merge this until after the release, there is no need to figure out what is wrong with VS2015. How did you get the VS2017 build to find Python3? We've had issues with that in another branch. |
|
I initially used CMake's Find_Python3 routine. It will set However, the default Python installation on Windows is 32-bit even if the operating system is on a 64-bit architecture. This causes incompatibility when linking CPython extension modules. That's why on Appveyor I set a custom |
|
I added unit tests to the Python bindings and binded them to the CTest suite 🙌. I believe this round of work (PR) is now complete from my side. |
|
@ShukantPal there have been major changes in the CI builds including dropping of VS2015 hence all the conflicts you are now seeing. There will be many fixes coming soon to If you decide to rebase the PR now for the build changes I do not think there will be any wasted work. The changes to the .yml files and CI scripts for adding the new tools are relatively minor and will likely not cause new conflicts. On the other hand I will not be merging this until the all the library fixes are in place so you are welcome to wait those are merged before rebasing. |
|
Thanks for the update, will look into this. |
#663