Vertex attributes missing from attribute array (regression)

[billhollings]

PR #1595 (which fixed issue #1592) introduced a smaller secondary regression that causes the following CTS tests to Fail instead of Pass:

dEQP-VK.pipeline.vertex_input.max_attributes.query_max_attributes.binding_one_to_one.interleaved
dEQP-VK.pipeline.vertex_input.max_attributes.query_max_attributes.binding_one_to_many.sequential

Any fix to this should be validated by the posters of the original issue #1592.

[spnda]

perhaps related, but CTS crashes for me on the following test case with the following Metal validation error:
dEQP-VK.robustness.robustness1_vertex_access.out_of_bounds_stride_30_middle_of_buffer

-[MTLVertexDescriptorInternal newSerializedDescriptor]:743: failed assertion `Serialized Descriptor Creation
None of the attributes set bufferIndex to 29, but MTLVertexDescriptor set buffer layout[29].stride(80).
'

[aitor-lunarg]

The issue comes from not correctly setting the maximum bound used vertex buffer binding. initReservedVertexAttributeBufferCount reserves more than the used vertex buffers by the pipeline. However, when we set the vertexDescriptor data for those buffers, we skip the ones that are not used.

This issue can fixed by ignoring the vertex buffers that are not used when we reserve the bindings. Hacked values to check if that would fix the issue and the tests pass. I need to get a better understanding on how to propose the change since the data we require for the solution is only filled after the function that calls initReservedVertexAttributeBufferCount. Will come back to this issue once remaining CTS failures are triaged. Leaving this as a note for myself, or for anyone wanting to fix the issue