-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pMessageIdName is always set to nullptr in MVKInstance::debugReportMessage() #2219
Comments
From the spec description of But I may be over interpreting, and I certainly like your idea of setting So, yes, a PR for this would be great, thanks! I guess of the two, the |
Thanks, I will proceed with a PR. One minor question however: If I move
Previously it was able to fprintf independently of whether Please let me know which approach you prefer. FYI - this issue is why I originally suggested just using |
Ah. Good point. What we generally do in this case is expose the support function as a stand-alone function. Search for |
BTW...no desperate hurry on this one, but if you could get the PR in by Monday (May 6), we can include it in the upcoming SDK release. |
Will do - thanks. PR now submitted with a question. See comments in #2224. |
When working on macOS/iOS fixes and updates in Sascha Willems' Vulkan examples project, I noticed that MoltenVK's
VkDebugUtilsMessengerCallbackDataEXT::pMessageIdName
is always set to nullptr inMVKInstance::debugReportMessage(MVKVulkanAPIObject* mvkAPIObj, MVKConfigLogLevel logLevel, const char* pMessage)
.Instead it should probably be set to
_debugReportCallbackLayerPrefix
orgetReportingLevelString(logLevel)
. This would allow the debug utils callback message to indicate the message is coming from MoltenVK via labels like:MoltenVK
(the simplest option), or evenmvk-error
,mvk-warn
, etc.Here is a before and after example...
Before:
WARNING: [0] : vkCreateMacOSSurfaceMVK() is deprecated. Use vkCreateMetalSurfaceEXT() from the VK_EXT_metal_surface extension.
After:
WARNING: [0][MoltenVK] : vkCreateMacOSSurfaceMVK() is deprecated. Use vkCreateMetalSurfaceEXT() from the VK_EXT_metal_surface extension.
or
WARNING: [0][mvk-warn] : vkCreateMacOSSurfaceMVK() is deprecated. Use vkCreateMetalSurfaceEXT() from the VK_EXT_metal_surface extension.
This analagous functionality to the Vulkan Loader, which populates the
pMessageIdName
field with things like:Loader Message
. For example:ERROR: [0][Loader Message] : loader_validate_device_extensions: Device extension VK_EXT_descriptor_buffer not supported by selected physical device or enabled layers.
I could provide a small PR to add this if you are interested. Please advise.
The text was updated successfully, but these errors were encountered: