Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO C++11 warnings for constexpr modifier on mvkGetReportingLevelString() #2229

Closed
SRSaunders opened this issue May 5, 2024 · 3 comments
Closed

Comments

@SRSaunders
Copy link
Contributor

SRSaunders commented May 5, 2024

Adding constexpr to mvkGetReportingLevelString() results in many clang warnings.

ISO C++11 does not allow conversion from string literal to 'char *'

I am using Ventura 13.6.6 with Xcode 15.2

(adding this here in case you did not see comment on closed PR #2224)

@SRSaunders
Copy link
Contributor Author

I can see that you fixed this in d2677a6

Thanks, closing

@billhollings
Copy link
Contributor

billhollings commented May 5, 2024

Yeah. Sorry That was my bad. That's what I get for using GitHub UI to change code functionality!

I should have just pulled your code in and tested locally to see if it warranted any mods.

Sorry for introducing the confusion. 🤦🏻‍♂️

And thanks for aiming to fix it!

@SRSaunders
Copy link
Contributor Author

No worries, thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants