Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify the user function for clEnqueueNativeKernel must be thread safe #1026

Merged
merged 1 commit into from Dec 5, 2023
Merged

clarify the user function for clEnqueueNativeKernel must be thread safe #1026

merged 1 commit into from Dec 5, 2023

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Dec 4, 2023

see #977

Clarifies that the application must ensure that the host-callable user function enqueued via clEnqueueNativeKernel is thread-safe.

alycm
alycm reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM textually.

I've read the discussion on the issue, there is a lot there, this change matches the final outcome of the discussion.

@bashbaug
Copy link
Contributor Author

bashbaug commented Dec 5, 2023

Merging as discussed in the December 5th teleconference.

@bashbaug bashbaug merged commit 4194edc into KhronosGroup:main Dec 5, 2023
2 checks passed
@bashbaug bashbaug deleted the more-thread-safe-callbacks branch March 3, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolherbst karolherbst karolherbst approved these changes

@alycm alycm alycm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bashbaug @karolherbst @alycm