New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strengthen requirements for CL_DEVICE_TYPE query #1069
strengthen requirements for CL_DEVICE_TYPE query #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Textually LGTM. Group needs to approve overall change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New wording still approved, it's very clear on returning a single value.
Had a thought: Would we want If so, I should adjust the descriptions of these devices types so it is clearer that this is allowed. In other words, |
I've updated this PR so it describes |
Proposed fix for #224.
This PR:
CL_DEVICE_TYPE_CUSTOM
must not be combined with any other device types to the description ofCL_DEVICE_TYPE
. (see (4) below)CL_DEVICE_TYPE_DEFAULT
must only be used to get device IDs usingclGetDeviceIDs
and must NOT be returned as theCL_DEVICE_TYPE
for any device.CL_DEVICE_TYPE_ALL
also must only be used to get device IDs usingclGetDeviceIDs
.Adds an informative note that most implementations should only return a single device type forUpdated: Adds the requirement that the device must return only a single device type forCL_DEVICE_TYPE
, and should not return a combination of device types.CL_DEVICE_TYPE
.