Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify clSetEventCallback behavior for command errors #1071

Merged

Conversation

bashbaug
Copy link
Contributor

Fixes #1068.

The callback registered for CL_COMPLETE will be called when the command completes successfully or when the command is abnormally terminated. This behavior used to be documented in a footnote but it is belongs in the main spec text instead.

The callback registered for CL_COMPLETE will be called when the
command completes successfully or when the command is abnormally
terminated.  This behavior used to be documented in a footnote
but it is belongs in the main spec text instead.
@bashbaug bashbaug requested a review from alycm February 27, 2024 00:32
@bashbaug bashbaug added this to In progress in OpenCL specification maintenance via automation Feb 27, 2024
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do not believe this changes any meanings, it just moves wording around and out of a footnote.

OpenCL specification maintenance automation moved this from In progress to Reviewer approved Feb 27, 2024
@bashbaug bashbaug merged commit a603b83 into KhronosGroup:main Mar 1, 2024
2 checks passed
OpenCL specification maintenance automation moved this from Reviewer approved to Done Mar 1, 2024
@bashbaug bashbaug deleted the clarify-event-callback-on-error branch March 1, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

clSetEventCallback callbacks being called on errors shouldn't be a footnote.
2 participants