Correct version that CL_DEPTH became core #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct other XML issues with cl_khr_depth_images and cl_khr_gl_depth_images, but the other changes have no visible affect on the specification. Fixes KhronosGroup#284
bashbaug
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Changes look good to me.
In case it helps other reviewers, the enums for CL_DEPTH_STENCIL and CL_UNORM_INT24 already exist in a block for cl_khr_gl_depth_images, which makes sense since they are not part of a core API.
I think the headers have a similar bug. I'll file an issue to correct this.
OpenCL 3.0 Final specifications
automation
moved this from Needs review
to Reviewer approved
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct other XML issues with cl_khr_depth_images and
cl_khr_gl_depth_images, but the other changes have no visible affect on the
specification.
Fixes #284