Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add specific memory and semaphore enums for CL_DEVICE_HANDLE_LIST_KHR #956

Merged
merged 3 commits into from Aug 22, 2023

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Aug 1, 2023

see #864

Instead of reusing the same CL_DEVICE_HANDLE_LIST_KHR, adds a memory-specific CL_MEM_DEVICE_HANDLE_LIST_KHR, and a semaphore-specific CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR.

Reuses the same value for CL_MEM_DEVICE_HANDLE_LIST_KHR as discussed. The enum value for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR is new, though.

@bashbaug
Copy link
Contributor Author

bashbaug commented Aug 1, 2023

Discussed in the August 1st teleconference:

  • Remove the symbol name completely. Note that this will require rephrasing a few places that currently use the asciidoc dictionary entry.
  • We will leave open another week or so for review.

@bashbaug
Copy link
Contributor Author

bashbaug commented Aug 1, 2023

I've made the changes to remove CL_DEVICE_HANDLE_LIST_KHR completely, as we discussed.

@bcalidas
Copy link

Looks ok

Copy link
Contributor

@nikhiljnv nikhiljnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikhiljnv
Copy link
Contributor

Merging as discussed on Aug 22 subgroup call.

@nikhiljnv nikhiljnv merged commit 3840543 into KhronosGroup:main Aug 22, 2023
2 checks passed
@bashbaug bashbaug deleted the unique-device-list-enums branch August 22, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants