Fix build of dependent software with clang #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using clang, altivec.h inclusion is taken care of by clang with -maltivec / -mno-altivec. Users shouldn't directly include it, it breaks compilation.
|
|
|
I'm fine merging this, but I do have one basic question (note, I am not an altivec expert!): Was including altivec.h ever valid for Clang? In other words, do we need a more precise Can we enhance our CI testing to catch this issue? Thanks! |
|
I don't think so, I have LLVM 10.0.1 right now, but I remember fixing other software that did the same back when I was using LLVM 8.0. 8.0 was the first version that was usable on ppc targets. Previous versions didn't support C++ exceptions. |
|
Thanks for the prompt reply. I'll merge this change - it's clearly broken now and we can always add improvements later, if necessary. |
bashbaug
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using clang, altivec.h inclusion is taken care of by clang with -maltivec / -mno-altivec. Users shouldn't directly include it, it breaks compilation.