Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on Windows since OCL_ICD_ENABLE_TRACE addition #170

Closed
BtbN opened this issue Apr 23, 2022 · 3 comments
Closed

Build failure on Windows since OCL_ICD_ENABLE_TRACE addition #170

BtbN opened this issue Apr 23, 2022 · 3 comments

Comments

@BtbN
Copy link

BtbN commented Apr 23, 2022

Hi!

Since the new environment variable was added, building the loader for Windows fails with the following error:

/stage/opencl/loader/loader/windows/icd_windows_apppackage.cpp:23:9: error: conflicting declaration of 'int khrEnableTrace' with 'C' linkage
   23 |     int khrEnableTrace;
      |         ^~~~~~~~~~~~~~
In file included from /stage/opencl/loader/loader/windows/icd_windows_apppackage.cpp:19:
/stage/opencl/loader/loader/icd.h:87:12: note: previous declaration with 'C++' linkage
   87 | extern int khrEnableTrace;
      |            ^~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/OpenCL.dir/build.make:181: CMakeFiles/OpenCL.dir/loader/windows/icd_windows_apppackage.cpp.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:95: CMakeFiles/OpenCL.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

Not entirely sure what the correct fix for this is. Maybe the header-include also needs wrapped in extern "C"?

@cdai2
Copy link
Contributor

cdai2 commented Apr 25, 2022

#171 is to fix this issue.
Sorry that this compilation error is not exposed on my local machine before.

@cdai2
Copy link
Contributor

cdai2 commented Apr 27, 2022

As #171 is landed. Please verify and close this issue. @BtbN

BtbN added a commit to BtbN/FFmpeg-Builds that referenced this issue Apr 27, 2022
@BtbN
Copy link
Author

BtbN commented Apr 27, 2022

Yep, all builds succeeded!

@BtbN BtbN closed this as completed Apr 27, 2022
okazunori2013 pushed a commit to okazunori2013/FFmpeg-Builds that referenced this issue Jan 3, 2023
Futsch1 pushed a commit to Futsch1/FFmpeg-Builds that referenced this issue Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants