Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use CMake defines for ICD loader name and vendor strings #203

Merged
merged 1 commit into from
Nov 25, 2022
Merged

do not use CMake defines for ICD loader name and vendor strings #203

merged 1 commit into from
Nov 25, 2022

Conversation

bashbaug
Copy link
Contributor

Using strings in target_compile_definitions can be complicated due to escape requirements for the double quotes in various build environments. Since we don't expect the OPENCL_ICD_LOADER_NAME_STRING and OPENCL_ICD_LOADER_VENDOR_STRING to change frequently - if ever - just define them in source files instead.

Fixes #202

@bashbaug bashbaug requested a review from Kerilk November 25, 2022 06:18
Kerilk
Kerilk approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@Kerilk Kerilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shameful that we have to work around what is obviously a tool chain bug, but I can't see a better solution for now. Thanks for fixing this issue. If we could incorporate mingw in the CI it would be good, else I assume we will break it again in the future.

@Kerilk Kerilk merged commit 9a3e962 into KhronosGroup:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerilk Kerilk Kerilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mingw build failed since commit 551a74d
2 participants
@bashbaug @Kerilk