Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path to pkg-config header file. #207

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Feb 13, 2023

This is the accompanying pull request for KhronosGroup/OpenCL-Headers#218

The first commit refactors the way the CI handles PKG_CONFIG_PATH.
The second commit updates the path to the newly adopted path in the Headers (failure is expected until the Headers are merged).

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

To merge this should we:

  • First merge the OpenCL headers changes.
  • Trigger a CI build.
  • Merge the changes assuming all tests pass?

@Kerilk
Copy link
Contributor Author

Kerilk commented Feb 22, 2023

This looks good to me.

To merge this should we:

* First merge the OpenCL headers changes.

* Trigger a CI build.

* Merge the changes assuming all tests pass?

Yes this is the plan. I will rerun the failed tests once the headers changes is through.

@bashbaug
Copy link
Contributor

Looks like everything is passing - awesome. Merging this one too...

@bashbaug bashbaug merged commit ece9144 into KhronosGroup:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants