Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add >VS2008 envvar #22

Closed
wants to merge 1 commit into from
Closed

Add >VS2008 envvar #22

wants to merge 1 commit into from

Conversation

mirh
Copy link

@mirh mirh commented Aug 25, 2017

Idk about VS2017 then (which in other news also add native cmake support)

Guess like some auto detection and selection of the highest installed Visual Studio version could have been figured out - but it's certainly going to result in something even more hackier than this
@bashbaug
Copy link
Contributor

bashbaug commented Feb 6, 2018

I think this is fine, but would it be even better to build using cmake instead of invoking nmake directly?

Then, the batch file could simply become:

set BUILD_DIR=build
set BIN_DIR=bin

mkdir %BUILD_DIR%
cd %BUILD_DIR%
cmake ../
cmake --build .
cd ..

@mirh
Copy link
Author

mirh commented Feb 7, 2018

Mh, well, that works too.
I wouldn't be sure about pros and cons of the thing though.
For example, a funny difference I noticed (aside from cmd spawning VS compiler logs, instead of a "gcc-like" progress screen) is that the exe manifest uses ' instead of " now.
This should be insignificant, but makes me wonder what's else.

@bashbaug
Copy link
Contributor

bashbaug commented Feb 8, 2018

Are the differences purely cosmetic? I can't think of any good reason why one method would be any more right than the other, just different.

To be clear, I'm OK with the proposed changes as-is, though it would be nice to avoid needing an update for each new VS version.

@kepatil any thoughts?

@kepatil
Copy link
Contributor

kepatil commented Jan 26, 2019

Are the differences purely cosmetic? I can't think of any good reason why one method would be any more right than the other, just different.

To be clear, I'm OK with the proposed changes as-is, though it would be nice to avoid needing an update for each new VS version.

@kepatil any thoughts?

I think building using cmake as you suggested is better. I'll make that change.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bashbaug
Copy link
Contributor

bashbaug commented Jul 9, 2019

We've removed the batch files and switched entirely to a CMake build system in #61, so I am closing this pull request.

@bashbaug bashbaug closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants