Small fixes from docs.gl #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from docs.gl commit c0daa7f4ee4d0fa.
Ported from docs.gl commit 9c7032ae58cd7
Ported from docs.gl commit dfcc8f26ef6fea1b
Ported from docs.gl commit 87538fd6fd7c2c8
Ported from docs.gl commit cf74ccc73ba84c
This is based on docs.gl commit 1d52b5bf8a6bc612, although with more info thrown in.
Ported from docs.gl commit c26c66f32eecf1.
Ported from docs.gl commit 441dd2a90316d94.
Ported from docs.gl commit 6df9031778065.
This was missed in commit 4e370c8.
Ported from docs.gl commit cc9ffdcca6bafd.
Ported from docs.gl commit 5808f8706b4d40.
Ported from docs.gl commit f74d877d279c2028d12.
|
Thanks! All LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the docs.gl repo (https://github.com/BSVino/docs.gl), looking for local fixes. This is the majority of the small ones. They had a few larger updates which I'll file as issues to better explain stuff (VAO required in core, glTexStorage making immutable textures). A handful here are not direct ports but rather fixes after checking for completeness of a fix.
I don't think there should be any licensing or attribution issues since the original text comes from Khronos in the first place, and these are all very minor updates.
@oddhack let me know if the way I pointed at the source commits is fine or if you want something else here.
Courtesy ping to @BSVino for awareness. Let me know if you feel like there are any problems with doing this.