gl.xml: Remove compatibility profile from GL_VERSION_3_0 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OpenGL/ES WG approves this change as long as @oddhack is happy. |
oddhack
requested changes
Jul 19, 2018
There was a problem hiding this comment.
I'm OK with the principle behind this, and it doesn't affect any of the generated headers, but I did notice a few more tweaks that should be done at the same time if @rijenkii doesn't mind updating the PR:
- GL_INDEX in GL 3.0 interfaces could be moved back into the previous <require> block
- The <require> block starting at 33935 should then be relabelled with comment="Reuse ARB_texture_float" - it was mixing tokens from both promoted extensions.
|
N.b. github's diff viewer is broken with files this large, IMO - it shows lines from two very different line ranges as contiguous, which can be very confusing. I reported this a while ago but no action yet :-( |
|
@oddhack Done! |
oddhack
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.