-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning comment to the <group> tags explaining that they may be out of date #291
Conversation
out of date. Fixes #280.
You might wanna take a look at #292 before you merge this PR |
#292 is a great maintenance PR, but I still think we should keep this warning in the spec as without Khronos' backing of the groupings, it won't be hard for PRs to slip through which degrade the validity of the groupings. |
Side note: Has the Khronos group investigated moving to the Vulkan specification format? (i.e. merging all enum groupings into |
@Perksey the Vulkan/OpenXR schema has some significant differences although it started off with the GL stuff, so it would be a lot of work to switch over. Not currently planned. |
Do you have XSD schemas for both? I can try and make an auto migrate
utility to take to the board’s next GL meeting. I’ve already converted the
GL spec into 3 different formats haha
…On Thu, 22 Aug 2019 at 04:08, Jon Leech ***@***.***> wrote:
@Perksey <https://github.com/Perksey> the Vulkan/OpenXR schema has some
significant differences although it started off with the GL stuff, so it
would be a lot of work to switch over. Not currently planned.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#291?email_source=notifications&email_token=ACVEYI7YVORZMLCNWENZTJDQFX7K7A5CNFSM4IKVNVYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43XLMA#issuecomment-523728304>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACVEYI7EFOTFLZP4SBZLMALQFX7K7ANCNFSM4IKVNVYA>
.
|
There are RNC schemas for both. Converting the XML file would be a small part of the problem, though. |
Thanks for the input on this PR so far. Any other comments before we accept this change? Thanks. |
After that change has been applied, this PR has my green light. |
@pdaniell-nv I think this should be OK now? AFAICT everyone's comments / requests have been incorporated. |
@oddhack yep looks good. Approved to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #280
Not in the sense of "making the group tags complete", but in the sense of "explaining that they aren't complete and we would need help in changing that".