-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create missing enumerations #45
Conversation
I am planning to add more as I have just finished writing a tool to discover missing groups |
When you're done with this, please squash it down to a single commit. All looks fine so far. |
@oddhack So I should close this PR when I'm done and re-open a new one containing a single commit? |
You can (if your git-fu is advanced enough) squash the commits in your local copy of the branch and force-push it to github, but your approach works too. |
This is done. I will now try and squash the thing before it starts laying eggs. |
@oddhack Done. |
add enum group information, it changed some parameter names and types incorrectly. Fixes #46.
@oddhack Ok, sorry for messing this up, I am trying to re-do this the right way now. Am I allowed to add group annotations for Like so: <command>
- <proto><ptype>GLenum</ptype> <name>glClientWaitSync</name></proto>
+ <proto group="SyncStatus"><ptype>GLenum</ptype> <name>glClientWaitSync</name></proto>
<param group="sync"><ptype>GLsync</ptype> <name>sync</name></param>
<param><ptype>GLbitfield</ptype> <name>flags</name></param>
<param><ptype>GLuint64</ptype> <name>timeout</name></param>
</command> |
That's fine. It's the actual API - e.g. the resulting headers - that we don't want to change without more careful attention. |
This pull request fills several missing enumerations