Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve 0x96E0-0x96EF for ANGLE project. #493

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

kenrussell
Copy link
Member

The project needs more enums for ANGLE-specific extensions.

@kenrussell
Copy link
Member Author

@oddhack please review.

@null77 @phuang @vonture @jonahryandavis FYI.

Copy link
Collaborator

@oddhack oddhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this collides with #492 which has precedence - same situation as your attempted reservation in EGL-Registry. So once @pdaniell-nv signs off on #492 and it's merged, this will need to be updated, or as before, I can just assign you the next free block after merging #492.

@pdaniell-nv
Copy link
Contributor

#492 is now approved to merge.

@oddhack
Copy link
Collaborator

oddhack commented Dec 15, 2021

@kenrussell this can be updated for the next free enum block now.

The project needs more enums for ANGLE-specific extensions.
@kenrussell kenrussell changed the title Reserve 0x96D0-0x96DF for ANGLE project. Reserve 0x96E0-0x96EF for ANGLE project. Dec 15, 2021
@kenrussell
Copy link
Member Author

Rebased.

@pdaniell-nv
Copy link
Contributor

@oddhack is this ready now?

@oddhack
Copy link
Collaborator

oddhack commented Jan 5, 2022

@oddhack is this ready now?

LGTM. If you're good as well, please tag the Milestone and I'll merge it then.

@pdaniell-nv
Copy link
Contributor

@oddhack is this ready now?

LGTM. If you're good as well, please tag the Milestone and I'll merge it then.

Done, approved to merge. Thanks.

@oddhack oddhack merged commit 92ab622 into KhronosGroup:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants