Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: fix deadlock in XrDestroyInstance #23

Commits on Mar 28, 2019

  1. validation: fix deadlock in XrDestroyInstance

    GenValidUsageNextXrDestroyInstance locks the non-recursive
    g_instance_dispatch_mutex and then calls GenValidUsageCleanUpMaps under the
    lock, which calls EraseAllInstanceTableMapElements, which tries to lock
    g_instance_dispatch_mutex again, causing a deadlock.
    Since EraseAllInstanceTableMapElements is only called from
    GenValidUsageNextXrDestroyInstance, g_instance_dispatch_mutex is always
    guaranteed to be locked, so drop the local std::unique_lock.
    pH5 committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f52a750 View commit details
    Browse the repository at this point in the history