Loader fixes #284
Merged
Loader fixes #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android if XR_KHR_LOADER_INIT_SUPPORT is defined but that method fails result will be set to a failure value. If next PlatformGetGlobalRuntimeFileName succeeds it doesn't set result to XR_SUCCESS failing when it should have succeeded.
rpavlik
reviewed
Dec 7, 2021
|
Looks great, thanks! Would you mind putting a brief changelog fragment in changes/sdk/pr.284.gh.OpenXR-SDK-Source.md? See the readme in that directory for instructions. |
rpavlik
approved these changes
Dec 7, 2021
rpavlik
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed loading of runtime on AOSP without a broker.