Enable helloxr building with latest Android Studio canary #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
force-pushed
the
build-helloxr-with-latest-AS-canary
branch
from
df0e7e4
to
068fafd
Compare
|
@rpavlik Great news, we can use AGP 7.4.x directly without previous cmake integration problems. |
|
I used command from https://docs.gradle.org/current/userguide/gradle_wrapper.html to update Gradle wrapper files including |
|
Excellent, thanks! |
rpavlik
reviewed
Apr 4, 2023
utzcoz
force-pushed
the
build-helloxr-with-latest-AS-canary
branch
2 times, most recently
from
125ffa4
to
3a35eb3
Compare
|
An issue (number 1983) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1983 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
utzcoz
commented
Apr 6, 2023
Looks like 7.4.2 fixes the cmake integration problem. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
utzcoz
force-pushed
the
build-helloxr-with-latest-AS-canary
branch
from
3a35eb3
to
e33bbd2
Compare
|
@rpavlik I think it is ready for reviewing again. |
|
@rpavlik Friendly ping for reviewing. |
rpavlik
approved these changes
Apr 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs us to upgrade Gradle version.