Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extraneous whitespace from xr.ml #397

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

satchelfrost
Copy link
Contributor

Removed extraneous whitespace from xr.ml that was effecting "PFN_xrCreateVulkanInstanceKHR", "PFN_xrCreateVulkanDeviceKHR", and "PFN_xrGetVulkanGraphicsDevice2KHR" in file openxr_platform.h.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

rpavlik commented Apr 20, 2023

This does make it match better, that's true. Was it causing a problem? I've considered adding that whitespace to all commands once I have the tool made to do so for structs.

@satchelfrost
Copy link
Contributor Author

It's not necessarily a problem, but whatever parses the xml to generate the code for openxr_platform.h takes into account that whitespace. For example the output on line 457 (I believe) of openxr_platorm.h is:

typedef XrResult (XRAPI_PTR *PFN_xrCreateVulkanInstanceKHR)(XrInstance instance, etc...

Which carries over the whitespace. So either the python script that reads that xml should not take into account whitespace, or just don't have extra whitespace in the xml to begin with.

In the end, it's not hurting anything.

@rpavlik
Copy link
Contributor

rpavlik commented Apr 20, 2023

ahh, sure. I've seen it do the same thing in the adoc. For some reason I thought the script auto-indented it when generating those.

@rpavlik rpavlik enabled auto-merge (rebase) April 27, 2023 15:16
@rpavlik rpavlik merged commit 3df37f7 into KhronosGroup:main Apr 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants