Fix some missing field initializer warnings #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this! I believe I just actually merged a similar MR internally that just hasn't made it to release yet, sorry for the duplication of effort. I'll double check to make sure the one I merged includes all these details. |
OK, so any plans to merge this soon? Anything else required from my side? |
The code was actually initializing the fields after the struct initialization but the compiler is not smart enough to acknowledge that. Explicitly initialize the fields one by one to remove the warnings.
rpavlik
force-pushed
the
missing-field-initialization
branch
from
a41e31c
to
deba3bf
Compare
|
I think |
|
A more complete change is coming in the next release soon, that I think handles all of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was actually initializing the fields after the struct initialization but the compiler is not smart enough to acknowledge that. Explicitly initialize the fields one by one to remove the warnings.