Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic float add should not imply Shader #257

Merged
merged 1 commit into from Dec 1, 2021
Merged

Atomic float add should not imply Shader #257

merged 1 commit into from Dec 1, 2021

Conversation

Hardcode84
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@antiagainst
Copy link
Contributor

+1. Thanks @Hardcode84! From the SPV_EXT_shader_atomic_float_add spec, AtomicFloat32AddEXT/AtomicFloat64AddEXT has no implied capabilities, but the commit to update JSON grammar has (7083cb5). So I think this is a proper fix to make sure the grammar follows the spec.

(We discovered this when trying to use OpAtomicFAddEXT for generating OpenCL kernels in MLIR/SPIR-V.)

@raunraun raunraun merged commit 29414ae into KhronosGroup:master Dec 1, 2021
@Hardcode84 Hardcode84 deleted the atomic-float-no-shader branch December 1, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hardcode84 @CLAassistant @antiagainst @raunraun