Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpEntryPoint: validate Interface objects #1120

Closed
dneto0 opened this issue Dec 19, 2017 · 1 comment
Closed

OpEntryPoint: validate Interface objects #1120

dneto0 opened this issue Dec 19, 2017 · 1 comment
Assignees
@alan-baker
Projects
Validator

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Dec 19, 2017

  • Interface objects are Ids of variables in Input or Output storage class.
  • If code in the static call tree of the entry point references an Input or Output variable, then the variable must be listed in the Interfaces list of the entry point
@dneto0 dneto0 created this issue from a note in Validator (Ready to start) Dec 19, 2017
@jeffbolznv
Copy link
Contributor

I've run into an app/project that ran afoul of this rule. Can we bump the priority of it?

@jeffbolznv jeffbolznv mentioned this issue Apr 23, 2018
Closed
@dneto0 dneto0 moved this from Ready to start to Suggested to start in Validator Apr 29, 2018
@alan-baker alan-baker moved this from Suggested to start to In progress in Validator May 28, 2018
@alan-baker alan-baker self-assigned this May 28, 2018
alan-baker added a commit to alan-baker/SPIRV-Tools that referenced this issue May 31, 2018
@alan-baker
Validate static uses of interfaces
e21dd52 
Fixes KhronosGroup#1120

Checks that all static uses of the Input and Output variables are listed
as interfaces in each corresponding entry point declaration.
 * Changed validation state to track interface lists
 * updated many tests
@alan-baker alan-baker mentioned this issue May 31, 2018
Closed
alan-baker added a commit to alan-baker/SPIRV-Tools that referenced this issue Jun 13, 2018
@alan-baker
Validate static uses of interfaces
44fce31 
Fixes KhronosGroup#1120

Checks that all static uses of the Input and Output variables are listed
as interfaces in each corresponding entry point declaration.
 * Changed validation state to track interface lists
 * updated many tests
@dneto0 dneto0 closed this as completed in 4f866ab Jun 13, 2018
@dneto0 dneto0 moved this from In progress to Done in Validator Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alan-baker alan-baker

Labels
None yet
Projects
Validator
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffbolznv @dneto0 @alan-baker