Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unifed1 headers from SPIRV-Headers #1195

Closed
dneto0 opened this issue Jan 12, 2018 · 4 comments
Closed

Use unifed1 headers from SPIRV-Headers #1195

dneto0 opened this issue Jan 12, 2018 · 4 comments
Assignees
Projects

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Jan 12, 2018

This is the way of the future.

It requires restructuring of grammar tables. I'm taking this one.

@dneto0
Copy link
Collaborator Author

dneto0 commented Jan 23, 2018

Since we're ingesting only one version of JSON file, we should have a single set of tables to represent the grammar. We need to represent each token as either: Reserved, Conditional, or Universal.

I plan to use the current representation of a token, but add a "min version" field so that:

  • Reservation uses min version of effectively SPV_ENV_UNIVERSAL_infinity
  • Conditional uses min version SPV_ENV_UNIVERSAL_1_2 for example when "version" in the grammar is "1.2"
  • Universal uses min version SPV_ENV_UNIVERSAL_1_0

Then you can have a total order for determining membership, where you select from SPV_ENV_UNIVERSAL_1_0, up through latest SPV_ENV_UNIVERSAL_1_2 and an internal-only "infinity" value. A target env of a client API, e.g. SPV_ENV_VULKAN_1_0 would map to representative value SPV_ENV_UNIVERSAL_1_0 for the purposes of comparison in this total order.

@dneto0
Copy link
Collaborator Author

dneto0 commented Feb 6, 2018

PR #1244 updates the #include directives to use the unified directories.

Still want to make unified grammar tables.

@antiagainst
Copy link
Contributor

#1413 implements this.

@dj2
Copy link
Contributor

dj2 commented Aug 15, 2018

Given #1413 landed, I'm going to close this as fixed.

@dj2 dj2 closed this as completed Aug 15, 2018
@dneto0 dneto0 moved this from In progress to Done in General Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants