Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII characters in a source file #4851

Closed
SausageTaste opened this issue Jul 9, 2022 · 0 comments
Closed

Non-ASCII characters in a source file #4851

SausageTaste opened this issue Jul 9, 2022 · 0 comments
Assignees
Labels

Comments

@SausageTaste
Copy link

// OpImageQuerySizeLod must only consume an “Image” operand whose type has

The double quote marks in text “Image” are unicode characters so they produce compile error on VS 2022 saying

[build] C:\Users\woos8\Documents\GitHub\Dalbaragi\extern\SPIRV-Tools\source\val\validate_image.cpp(1530,1): error C2220: the following warning is treated as an error [C:\Users\woos8\Documents\GitHub\Dalbaragi\build\lib\SPIRV-Tools\source\SPIRV-Tools-static.vcxproj]
[build] C:\Users\woos8\Documents\GitHub\Dalbaragi\extern\SPIRV-Tools\source\val\validate_image.cpp(1530,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss [C:\Users\woos8\Documents\GitHub\Dalbaragi\build\lib\SPIRV-Tools\source\SPIRV-Tools-static.vcxproj]

They are actually 3 bytes unicode characters

2022-07-10 (1)

Just replacing them with " fixed the issue for me but it made the submodule 'dirty'.
Hope it gets corrected.

Thanks.

s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Mar 29, 2023
@s-perron s-perron self-assigned this Mar 29, 2023
@s-perron s-perron added the bug label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants