Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing dependency on spir.h, GLSL.std.450.h, OpenCL.std.h #7

Closed
dneto0 opened this issue Nov 17, 2015 · 0 comments
Closed

missing dependency on spir.h, GLSL.std.450.h, OpenCL.std.h #7

dneto0 opened this issue Nov 17, 2015 · 0 comments
Assignees
@dneto0

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Nov 17, 2015

When spir.h changes, we should rebuild objects that depend on it.
@antiagainst antiagainst self-assigned this Nov 17, 2015
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Nov 17, 2015
@dneto0
Object files should depend on spirv.h and friends
748d585 
Don't use SYSTEM attribute on include_directories directive
for the SPIR-V standard header files.  When you do, object files
are not considered dependent on those headers.

Checked by looking at the dependency file source/disassemble.cpp.o.d,
and by trying to compile after a trivial edit to spirv.h

Fixes KhronosGroup#7

Also, use "" inclusion instead of <> inclusion for standard SPIR-V
headers.
@dneto0 dneto0 mentioned this issue Nov 17, 2015
Merged
@antiagainst antiagainst assigned dneto0 and unassigned antiagainst Nov 18, 2015
@dneto0 dneto0 mentioned this issue Sep 19, 2017
Closed
This was referenced Nov 24, 2017
Closed
Merged
dgkoch pushed a commit to dgkoch/SPIRV-Tools that referenced this issue Nov 21, 2018
@oddhack
Fixes KhronosGroup#7.
231ae2e 
Direct people to file header issues in github, not bugzilla.
dgkoch pushed a commit to dgkoch/SPIRV-Tools that referenced this issue Nov 21, 2018
@oddhack
Merge pull request KhronosGroup#8 from KhronosGroup/issue-7-README
34d319d 
Fixes KhronosGroup#7. Direct people to file header issues in github, not bugzilla.
@dneto0 dneto0 mentioned this issue Jan 16, 2019
Closed
@dneto0 dneto0 mentioned this issue Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dneto0 dneto0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antiagainst @dneto0