Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator: Should allow OpTypePointer with same pointee type and storage class #781

Closed
dneto0 opened this issue Aug 29, 2017 · 3 comments
Closed

Validator: Should allow OpTypePointer with same pointee type and storage class #781

dneto0 opened this issue Aug 29, 2017 · 3 comments
Assignees
@atgoo

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Aug 29, 2017

This is exercised by SPV_KHR_variable_pointers.

See the "Types" subsection of
https://www.khronos.org/registry/spir-v/extensions/KHR/SPV_KHR_variable_pointers.html#_modifications_to_the_spir_v_specification_version_1_1
@dneto0
Copy link
Collaborator Author

dneto0 commented Aug 29, 2017

Could either be precise, and enable this behaviour only when either of the variable pointers capabilities is enabled, or could be blunt and always enable this.

@dneto0
Copy link
Collaborator Author

dneto0 commented Aug 29, 2017

The variable pointers extension allows you to have two OpTypePointer with the same storage class and pointee type, but the pointer types have ArrayStride decorations. The decorations might have the same value or different.

@dneto0 dneto0 changed the title Validator: Should allow OpTypePointer that differs only in decoration Validator: Should allow OpTypePointer with same pointee type and storage class Aug 29, 2017
atgoo pushed a commit to atgoo/SPIRV-Tools that referenced this issue Aug 29, 2017
Extension allows multiple same OpTypePointer types
6930bdc 
SPV_KHR_variable_pointers allows OpTypePointer to declare multiple
identical types if they have different declarations.

KhronosGroup#781
@atgoo atgoo mentioned this issue Aug 29, 2017
Closed
dneto0 pushed a commit that referenced this issue Sep 1, 2017
@dneto0
Extension allows multiple same OpTypePointer types
725284c 
SPV_KHR_variable_pointers allows OpTypePointer to declare multiple
pointer identical types.

#781
@dneto0
Copy link
Collaborator Author

dneto0 commented Sep 1, 2017

Fixed by #783

@dneto0 dneto0 closed this as completed Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atgoo atgoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atgoo @dneto0