Add memory semantics checks to validate atomics #1234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dneto0
approved these changes
Jan 30, 2018
| @@ -23,6 +23,89 @@ | |||
|
|
|||
| namespace libspirv { | |||
|
|
|||
| // Returns number of '1' bits in a word. | |||
| uint32_t CountSetBits(uint32_t word) { | |||
There was a problem hiding this comment.
FYI this is also known as "population count" or popcount which is sometimes a builtin in some compilers.
But this is fine. :-)
|
Rebased and pushed onto master as 44d88c8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
Memory semantics checks are performed if the bit field was declared as int constant.