Remove old names for enums: memory semantics, scope ID #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+2 |
cnorthrop
pushed a commit
to cnorthrop/SPIRV-Tools
that referenced
this pull request
May 23, 2017
It's the top 16 bits of the generator word. Test output expects a relatively recent versions of: - SPIRV-Tools: parses tools identities from the SPIR-V XML Registry file - SPIRV-Headers: defines the "Google over Shaderc" generator as tool KhronosGroup#13
This was referenced Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer the new names because they end with "ID" and match the section headers in the SPIR-V spec. They are:
Remove the uses of the old names.
Also ran clang-format on the affected files. In one case, the reformatting of a table was painfully different, so I added a "clang-format off" directive around it.