Put DiagnosticStream and clr exports in libspirv namespace #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each exported functions either has an "spv" prefix, or is inthe libspirv namespace. Fixes KhronosGroup#18
| @@ -27,6 +27,8 @@ | |||
| #include "print.h" | |||
|
|
|||
| #if defined(SPIRV_LINUX) || defined(SPIRV_MAC) | |||
| namespace libspirv { | |||
There was a problem hiding this comment.
I think this can be moved above the #if macro check so we don't need to have to duplicate it again for the windows case.
There was a problem hiding this comment.
I thought about that while coding it. I didn't want to have a namespace libspirv around the #include of <Windows.h> So either we have to declare the libspirv namespace twice, or we have to do the conditional compilation of defined(SPIRV_WINDOWS) twice.
Sorry I didn't reply to this earlier.
There was a problem hiding this comment.
That makes sense. Thanks!
|
+2 with minor nitpicks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each exported functions either has an "spv" prefix, or is in the libspirv
namespace.
Fixes #18