Fixing some C++ conversion errors. #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benvanik
commented
Nov 22, 2015
benvanik
commented
- Implicit conversion from int to bool.
- Implicit conversion from size_t to uint32_t.
- Implicit conversion from char* to uint8_t.
| @@ -499,7 +499,7 @@ spv_result_t AssemblyContext::checkRangeAndIfHexThenSignExtend( | |||
| // Hex values are a bit special. They decode as unsigned values, but | |||
| // may represent a negative number. In this case, the overflow bits | |||
| // should be zero. | |||
| failed = (value & overflow_mask); | |||
| failed = (value & overflow_mask) ? true : false; | |||
There was a problem hiding this comment.
This is pointless. Does it solve a compilation problem?
* Implicit conversion from int to bool. * Implicit conversion from size_t to uint32_t. * Implicit conversion from char* to uint8_t.
dekimir
pushed a commit
that referenced
this pull request
Nov 23, 2015
Fixing some C++ conversion errors. * Implicit conversion from int to bool. * Implicit conversion from size_t to uint32_t. * Implicit conversion from char* to uint8_t. Adding no-op color operators so unhandled platforms can still link.
|
LGTM, merged. Thanks, Ben! |
dgkoch
pushed a commit
to dgkoch/SPIRV-Tools
that referenced
this pull request
Nov 21, 2018
…nges Clarify opcode/enum ranges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.