Several unit tests for spvBinaryParse #28
Conversation
| // Returns true if two spv_parsed_operand_t values are equal. | ||
| // To use this operator, this definition must appear in the same namespace | ||
| // as spv_parsed_operand_t. | ||
| static bool operator==(const spv_parsed_operand_t& a, |
There was a problem hiding this comment.
Didn't we say we'll use anonymous namespace instead of static?
There was a problem hiding this comment.
Yes, but that doesn't compile, as alluded to in the blurb comment.
This is the error you get if you put the operator in the anonymous namespace instead:
stl_algobase.h: In instantiation of ‘static bool std::__equal<_BoolType>::equal(_II1, _II1, _II2) [with II1 = const spv_parsed_operand_t; II2 = const spv_parsed_operand_t; bool _BoolType = false]’:
...
/sr/include/c++/4.8/bits/stl_algobase.h:797:22: error: no match for ‘operator==’ (operand types are ‘const spv_parsed_operand_t’ and ‘const spv_parsed_operand_t’)
and about 630 more lines of errors showing you various things it tried.
The problem is that spv_parse_operand_t is declared outside of any namespace. So an equality operator on it must be in the same namespace.
There was a problem hiding this comment.
Ah, right, that makes sense. Hopefully the C++ interface from #2 will obviate the need for local operator== everywhere.
There was a problem hiding this comment.
Yes, I expect that.
|
+2 |
Add a non-zero spv_result_t value SPV_REQUESTED_TERMINATION which should be used to signal an ok result, but signals early termination for a process, such as binary parsing. Tests include: - correct contents sent to header and instruction callbacks - non-zero status from a callback should terminate parsing, but the parser should not generate its own diagnostic. TODO: Check diagnostics generated by the parser itself.
dneto0
force-pushed
the
unit-test-binary-parse
branch
from
f92e9cc
to
750f205
Compare
|
Squashed and pushed into master. |
Add a non-zero spv_result_t value SPV_REQUESTED_TERMINATION
which should be used to signal an ok result, but signals
early termination for a process, such as binary parsing.
Tests include:
but the parser should not generate its own diagnostic.
TODO: Check diagnostics generated by the parser itself.