spirv-val: Add support for SPV_AMD_shader_image_load_store_lod #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alan-baker
requested changes
Feb 13, 2020
According to SPV_AMD_shader_image_load_store_lod spec, Lod operand is valid with OpImageRead, OpImageWrite, or OpImageSparseRead if the extension is enabled.
samuelig
force-pushed
the
SPV_AMD_shader_image_load_store_lod
branch
from
a2845c2
to
0bdf278
Compare
alan-baker
approved these changes
Feb 14, 2020
|
CI-shaderc-smoketest check is failing because glslang expects a validation failure on a SPV_AMD_shader_image_load_store_lod test . I have a fix here. Should I land glslang fix first for review? Or land this first and then the glslang fix? Which is the procedure for this case? |
Glslang pull request: KhronosGroup/glslang#2086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SPV_AMD_shader_image_load_store_lod spec, Lod operand is
valid with OpImageRead, OpImageWrite, or OpImageSparseRead if the
extension is enabled.