Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for issue #3237 #3238

Merged
merged 4 commits into from Jun 10, 2020
Merged

Conversation

Vasniktel
Copy link
Collaborator

Test for #3237.

@Vasniktel
Copy link
Collaborator Author

This file is used as a donor in the test case (compiled using clspv).

@s-perron s-perron requested a review from afd March 17, 2020 19:44
@Vasniktel
Copy link
Collaborator Author

It seems I messed with the git here :)

@Vasniktel
Copy link
Collaborator Author

It seems that FuzzerPassDonateModules doesn't support StorageBuffer storage class here.

SpvStorageClass FuzzerPassDonateModules::AdaptStorageClass(
SpvStorageClass donor_storage_class) {
switch (donor_storage_class) {
case SpvStorageClassFunction:
case SpvStorageClassPrivate:
case SpvStorageClassWorkgroup:
// We leave these alone
return donor_storage_class;
case SpvStorageClassInput:
case SpvStorageClassOutput:
case SpvStorageClassUniform:
case SpvStorageClassUniformConstant:
case SpvStorageClassPushConstant:
case SpvStorageClassImage:
// We change these to Private
return SpvStorageClassPrivate;
default:
// Handle other cases on demand.
assert(false && "Currently unsupported storage class.");
return SpvStorageClassMax;
}
}

@afd, should I create an issue?

@afd
Copy link
Contributor

afd commented May 14, 2020

@Vasniktel yes please

@Vasniktel
Copy link
Collaborator Author

@afd added an issue #3347.

@Vasniktel Vasniktel requested a review from afd May 15, 2020 13:49
@afd
Copy link
Contributor

afd commented May 19, 2020

Can you please rebase, @Vasniktel ?

@Vasniktel
Copy link
Collaborator Author

Can you please rebase, @Vasniktel ?

Done.

@afd
Copy link
Contributor

afd commented May 21, 2020

@Vasniktel This is still failing CI due to a missing storage class. However, I believe you added that via 5225616. Did you definitely rebase against master having updated master to be past 5225616?

@Vasniktel
Copy link
Collaborator Author

Vasniktel commented May 21, 2020

@afd I'm pretty sure I did. I'll investigate more.

@paulthomson
Copy link
Contributor

The rebase looks correct

@Vasniktel
Copy link
Collaborator Author

The problem occurs here

default: {
assert(0 && "Unknown type/value.");
new_result_id = 0;
} break;

It seems that FuzzerPassDonateModules doesn't support OpSpecConstant instructions.

@Vasniktel Vasniktel requested a review from afd June 10, 2020 05:01
@afd afd merged commit e498967 into KhronosGroup:master Jun 10, 2020
@Vasniktel Vasniktel deleted the opencl_donor_fails_test branch June 10, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants