Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-fuzz: Make is_irrelevant parameters non-default #3583

Merged
merged 1 commit into from Jul 24, 2020
Merged

spirv-fuzz: Make is_irrelevant parameters non-default #3583

merged 1 commit into from Jul 24, 2020

Conversation

Vasniktel
Copy link
Collaborator

Fixes #3177.

@afd afd added the kokoro:run label Jul 23, 2020
afd
afd approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks for completing this big change!

@afd afd merged commit d630653 into KhronosGroup:master Jul 24, 2020
@Vasniktel Vasniktel deleted the use_non_default_parameters branch July 24, 2020 08:50
dnovillo pushed a commit to dnovillo/SPIRV-Tools that referenced this pull request Aug 19, 2020
@Vasniktel @dnovillo
spirv-fuzz: Don't use default parameters (KhronosGroup#3583)
72865cd 
Fixes KhronosGroup#3177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afd afd afd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spirv-fuzz: Add fact to id uses to make it clear they could be fuzzed.
3 participants
@Vasniktel @afd @kokoro-team