Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-fuzz: Relax type constraints in DataSynonym facts #3602

Merged
merged 2 commits into from Jul 29, 2020
Merged

spirv-fuzz: Relax type constraints in DataSynonym facts #3602

merged 2 commits into from Jul 29, 2020

Conversation

Vasniktel
Copy link
Collaborator

Fixes #3595.

afd
afd suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have suggested a slightly different approach which is a bit clearer to me - I was not that keen on the idea of tracking element count when the type needn't even be a scalar or vector (e.g. it could be a struct or array or whatever).

source/fuzz/fact_manager.cpp Outdated Show resolved Hide resolved
source/fuzz/fact_manager.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_apply_id_synonyms.cpp Outdated Show resolved Hide resolved
@Vasniktel Vasniktel requested a review from afd July 28, 2020 09:56
@Vasniktel Vasniktel mentioned this pull request Jul 28, 2020
Merged
afd
afd approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - LGTM.

@afd afd added the kokoro:run label Jul 29, 2020
@afd afd merged commit 863b8e3 into KhronosGroup:master Jul 29, 2020
@Vasniktel Vasniktel deleted the relax_type_constraints branch July 29, 2020 16:48
dnovillo pushed a commit to dnovillo/SPIRV-Tools that referenced this pull request Aug 19, 2020
@Vasniktel @dnovillo
spirv-fuzz: Relax type constraints in DataSynonym facts (KhronosGroup…
573722d 
…#3602)

Fixes KhronosGroup#3595.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afd afd afd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spirv-fuzz: Relax type constraints on DataSynonym facts
3 participants
@Vasniktel @afd @kokoro-team