Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-fuzz: Handle OpPhi during constant obfuscation #3640

Merged
merged 4 commits into from Aug 5, 2020
Merged

spirv-fuzz: Handle OpPhi during constant obfuscation #3640

merged 4 commits into from Aug 5, 2020

Conversation

Vasniktel
Copy link
Collaborator

Fixes #3639.

paulthomson
paulthomson reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@paulthomson paulthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! A few minor comments about...comments.

source/fuzz/fuzzer_util.h Outdated Show resolved Hide resolved
source/fuzz/transformation_replace_constant_with_uniform.cpp Outdated Show resolved Hide resolved
source/fuzz/transformation_replace_constant_with_uniform.cpp Outdated Show resolved Hide resolved
@paulthomson paulthomson merged commit a10e760 into KhronosGroup:master Aug 5, 2020
@Vasniktel Vasniktel deleted the fix_obfuscation branch August 5, 2020 18:32
dnovillo pushed a commit to dnovillo/SPIRV-Tools that referenced this pull request Aug 19, 2020
@Vasniktel @dnovillo
spirv-fuzz: Handle OpPhi during constant obfuscation (KhronosGroup#3640)
166a8a7 
Fixes KhronosGroup#3639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulthomson paulthomson paulthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spirv-fuzz: TransformationReplaceConstantWithUniform doesn't handle OpPhi instructions
3 participants
@Vasniktel @paulthomson @kokoro-team