Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-fuzz: Handle OpPhis in livesafe functions #3642

Merged
merged 6 commits into from Aug 5, 2020
Merged

spirv-fuzz: Handle OpPhis in livesafe functions #3642

merged 6 commits into from Aug 5, 2020

Conversation

Vasniktel
Copy link
Collaborator

@Vasniktel Vasniktel commented Aug 2, 2020 •
edited

Fixes #3641.

@Vasniktel Vasniktel marked this pull request as draft August 2, 2020 18:48
@Vasniktel
Copy link
Collaborator Author

Converted to draft since it requires tests.

paulthomson
paulthomson reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@paulthomson paulthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
@Vasniktel Vasniktel marked this pull request as ready for review August 4, 2020 09:37
paulthomson
paulthomson reviewed Aug 4, 2020
View reviewed changes
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
paulthomson
paulthomson reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@paulthomson paulthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! A few minor suggestions that I think will improve readability.

source/fuzz/fuzzer_pass_donate_modules.cpp Outdated Show resolved Hide resolved
@Vasniktel Vasniktel force-pushed the handle_op_phi_in_livesafe_functions branch from 7fa0797 to c89d2e6 Compare August 5, 2020 11:20
@paulthomson paulthomson merged commit 0419751 into KhronosGroup:master Aug 5, 2020
@Vasniktel Vasniktel deleted the handle_op_phi_in_livesafe_functions branch August 5, 2020 18:32
dnovillo pushed a commit to dnovillo/SPIRV-Tools that referenced this pull request Aug 19, 2020
@Vasniktel @dnovillo
spirv-fuzz: Handle OpPhis in livesafe functions (KhronosGroup#3642)
08dfe8e 
Fixes KhronosGroup#3641.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulthomson paulthomson paulthomson approved these changes

@andreperezmaselco andreperezmaselco Awaiting requested review from andreperezmaselco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spirv-fuzz: FuzzerPassDonateModules doesn't handle OpPhis in livesafe functions
4 participants
@Vasniktel @paulthomson @andreperezmaselco @kokoro-team