Do run DCE if SPV_KHR_ray_query is used. #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnovillo
approved these changes
Dec 2, 2020
|
Will wait for the bots to go green |
MarijnS95
added a commit
to MarijnS95/SPIRV-Tools
that referenced
this pull request
Dec 4, 2020
Similar to [1] DCE should be ran when this extension is enabled to prevent unused bindings from showing up (in particular atomic counters attached to buffers). [1]: KhronosGroup#4047
s-perron
pushed a commit
that referenced
this pull request
Dec 7, 2020
Similar to [1] DCE should be ran when this extension is enabled to prevent unused bindings from showing up (in particular atomic counters attached to buffers). [1]: #4047
MarijnS95
added a commit
to MarijnS95/DirectXShaderCompiler
that referenced
this pull request
Jan 19, 2021
KhronosGroup/SPIRV-Tools#4047 enabled DCE for vk::ReadClock which we're using. Without this patch unused bindings for atomic counters attached to buffers show up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support for
KHR_ray_queryandKHR_ray_tracinglanded in SPIRV-Tools, it missed adding ray_query to acceptable extensions for DCE.Fixes microsoft/DirectXShaderCompiler#3287