Handle exported functions in ADCE #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADCE does not handle exported functions. This was an explicit decision because we did not believe that the linkage attribute could be used in shaders, but it can now. This change has been made. While fixing this error, I noticed that the OpName for labels is sometimes removed because the label instructions are not marked explicitly marked as live. This has able been fixed.
Which extension changed this? |
|
I don't know about Vulkan, but DX can create libraries. The idea is to allow something similar to shader linking in DX: https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/using-shader-linking. There is some work in DXC to emulate that behaviour. I think the plan is to do some type of linking in the driver. See microsoft/DirectXShaderCompiler#3234 (comment). |
alan-baker
approved these changes
Aug 31, 2021
|
@jiaolu FYI: this is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADCE does not handle exported functions. This was an explicit decision
because we did not believe that the linkage attribute could be used in
shaders, but it can now. This change has been made.
While fixing this error, I noticed that the OpName for labels is
sometimes removed because the label instructions are not marked
explicitly marked as live. This has able been fixed.