Add preserve_interface mode to aggressive_dead_code_elim #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alan-baker PTAL since you wrote the original code. The shaderc and ubsan failures do not look to be related to my changes. |
alan-baker
approved these changes
Sep 12, 2021
|
@jaebaek @dnovillo Given that @alan-baker has approved and the current CI failures are not related to my change, can someone please merge? |
|
The error says It was fixed by #4522. |
This mode is needed by GPU-assisted validation instrumentation which cannot change the shader entry point interface.
airlied
added a commit
to airlied/SPIRV-Tools
that referenced
this pull request
Dec 6, 2021
The change in commit 4ac8e5e Author: Greg Fischer <greg@lunarg.com> Date: Wed Sep 15 12:38:34 2021 -0600 Add preserve_interface mode to aggressive_dead_code_elim (KhronosGroup#4520) Broke the C++ ABI for spirv-tools shared libraries on Linux, for not a great reason. Restore the previous ABI.
airlied
added a commit
to airlied/SPIRV-Tools
that referenced
this pull request
Dec 9, 2021
The change in commit 4ac8e5e Author: Greg Fischer <greg@lunarg.com> Date: Wed Sep 15 12:38:34 2021 -0600 Add preserve_interface mode to aggressive_dead_code_elim (KhronosGroup#4520) Broke the C++ ABI for spirv-tools shared libraries on Linux, for not a great reason. Restore the previous ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mode is needed by GPU-assisted validation instrumentation which
needs to do ADCE but cannot change the shader entry point interface.