Complete handling of RayQueryKHR type #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of the RayQueryKHR type is not complete in the type manager. The tests were not picking this up. I've added a test to make sure that the `GenerateAllTypes` function actually does generate all of the types. Once it is added there other tests should pick up on the other parts that were missing.
alan-baker
approved these changes
Jan 31, 2022
dneto0
added a commit
to dneto0/shaderc
that referenced
this pull request
Feb 2, 2022
SPIRV-Tools v2022.1 plus: - Validator handles Nontemporal image operand KhronosGroup/SPIRV-Tools#4692 - Optimizer handles RayQueryKHR type KhronosGroup/SPIRV-Tools#4690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of the RayQueryKHR type is not complete in the type
manager. The tests were not picking this up. I've added a test to make
sure that the
GenerateAllTypesfunction actually does generate all ofthe types. Once it is added there other tests should pick up on the
other parts that were missing.