Add more folding for composite instructions #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fold chains of insert into construct If a chain of OpCompositeInsert instruction write to every element of a composite object, then we can replace it with an OpCompositeConstruct. Fold a construct fed by extracts to a single extract We already fold an OpCompositeConstruct when it is simlpy reconstructing an object that was decomposed by a series of OpCompositeExtract instructions. However, we do not do that if that object is an element of a larger object. I have updated the rule, so that if the original object is a an element of a larger object, then the OpCompositeConstruct is replaced with a single OpCompositeExtract from the larger object. Fixes KhronosGroup#4371.
vettoreldaniele
approved these changes
May 16, 2022
s-perron
changed the title
|
CC @prideout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold chains of insert into construct
If a chain of OpCompositeInsert instruction write to every element of a
composite object, then we can replace it with an OpCompositeConstruct.
Fold a construct fed by extracts to a single extract
We already fold an OpCompositeConstruct when it is simlpy reconstructing
an object that was decomposed by a series of OpCompositeExtract
instructions. However, we do not do that if that object is an element
of a larger object.
I have updated the rule, so that if the original object is a an element
of a larger object, then the OpCompositeConstruct is replaced with a
single OpCompositeExtract from the larger object.
Fixes #4371.