Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-val: Add SPV_KHR_ray_query #4848

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Conversation

sjfricke
Copy link
Contributor

@sjfricke sjfricke commented Jul 6, 2022

Adds basic validation for all OpRayQuery* instructions operands/result types

Might not work with CI if it hards code ./test/val/val_stuvw as name has been updated to val_rstuvw

task list KhronosGroup/Vulkan-Docs#1402 (cc @dgkoch in case I beat someone to this and prevent them from duplicating work, but didn't see an open issue on this)

@sjfricke
Copy link
Contributor Author

seems some builds don't like __attribute__((fallthrough));.... to just save wasting another failed CI run, just removed the fallthrough for a normal if statement inside

Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer some more specific error messages, but looks good otherwise.

source/val/validate_ray_query.cpp Outdated Show resolved Hide resolved
source/val/validate_ray_query.cpp Outdated Show resolved Hide resolved
source/val/validate_ray_query.cpp Show resolved Hide resolved
@alan-baker alan-baker merged commit e4cfa19 into KhronosGroup:master Jul 20, 2022
@sjfricke sjfricke deleted the sjfricke-rq2 branch August 23, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants