Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ColMajor or RowMajor for matrices #4878

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Require ColMajor or RowMajor for matrices #4878

merged 3 commits into from
Jul 29, 2022

Conversation

alan-baker
Copy link
Contributor

Fixes #4875

  • Require that matrices in laid out structs have RowMajor or ColMajor
    set as per SPIR-V section 2.16.2 (shader validation)

@alan-baker
Require ColMajor or RowMajor for matrices
97c7c87 
Fixes KhronosGroup#4875

* Require that matrices in laid out structs have RowMajor or ColMajor
  set as per SPIR-V section 2.16.2 (shader validation)
@alan-baker alan-baker requested a review from dneto0 July 29, 2022 14:48
@alan-baker alan-baker self-assigned this Jul 29, 2022
@alan-baker alan-baker added this to In progress in Validator via automation Jul 29, 2022
@alan-baker
Rework check
fec3b2f 
* Change checkForRequiredDecoration to take a functor
@alan-baker
formatting
4ad9114
dneto0
dneto0 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Another check should be made, but requires a bunch more code: That ColMajor and RowMajor are mutually exclusive.

@alan-baker
Copy link
Contributor Author

The exclusive check is actually already checked elsewhere (in CheckDecorationsCompatibility).

@alan-baker alan-baker merged commit b5d0bf2 into KhronosGroup:master Jul 29, 2022
Validator automation moved this from In progress to Done Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees

@alan-baker alan-baker

Labels
component:validation
Projects
Validator
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator doesn't require ColMajor or RowMajor decoration
2 participants
@alan-baker @dneto0