Fix array copy propagation #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
s-perron
requested changes
Aug 11, 2022
There was a problem hiding this comment.
Good find. I think the only issue has to do with a detail of the spec you are probably not aware of. The reason this fail is because there was a change and DXC had to start putting more thing on the OpEntryPoint, and that case was not handled. See https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#OpEntryPoint.
Just make sure the test says it is spv1.4.
s-perron
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Array copy propagation was interpreting OpEntryPoint as a store, and therefore not propagating arrays passed into the shader.
Fixes microsoft/DirectXShaderCompiler#4444