spirv-opt: Fix stacked CompositeExtract constant folds #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjfricke
force-pushed
the
sjfricke-stackedop
branch
from
f681c2c
to
c834671
Compare
s-perron
approved these changes
Sep 13, 2022
| "OpFunctionEnd", | ||
| // clang-format on | ||
| }; | ||
| SinglePassRunAndCheck<FoldSpecConstantOpAndCompositePass>( |
There was a problem hiding this comment.
This is fine for this PR, but, for any future PRs, we prefer the SinglePassRunAndMatch tests. Having the "Check" instructions using regex makes the tests less likely to need updating, and it make the important part of the change more obvious.
There was a problem hiding this comment.
ok, so SinglePassRunAndCheck is being used in fold_spec_const_op_composite_test.cpp instead of SinglePassRunAndMatch and new to test/opt so wasn't aware, looks way nicer to use
|
@s-perron friendly ping if this is still waiting on anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spotted in the Validation Layers where
OpSpecConstantOp %x CompositeExtract %y 0was being folded to a constant, but anything that was using it wasn't recognizing it as a constant, the simple fix was to add aconst_mgr->MapInst(new_const_inst);so the next instruction knew it was a const